Ensure commands always silent for MSVC #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
force-pushed
the
long-quiet-command
branch
from
f9124f5
to
5a52106
Compare
alainfrisch
reviewed
Apr 22, 2020
| let oc = open_out fn in | ||
| output_string oc cmd; | ||
| close_out oc; | ||
| ignore (Sys.command invoke) |
There was a problem hiding this comment.
What's the purpose of running the command again without the redirection? We don't do that in the "direct" case (where bash is not used); and we might get errors (printed to stderr) twice.
There was a problem hiding this comment.
Yes we do - see deleted lines 224 and 225 below.
It's a good point, though - the treatment on the other branch is for MSVC where errors are also sent to stdout. I think the correct thing is probably to do &>/dev/null on this side and a belt-and-braces 2>&1 on the other?
There was a problem hiding this comment.
The whole lot exists to get rid of those pesky "foo.c" lines from MSVC...
dra27
force-pushed
the
long-quiet-command
branch
from
5a52106
to
92ee954
Compare
If a command is routed through bash because it's too long, the fact it's meant to be piped to NUL is forgotten. Ensure the bash command is piped to >/dev/null (with the slightly tedious recovery of the script needed if the command fails).
dra27
force-pushed
the
long-quiet-command
branch
from
92ee954
to
09a34ad
Compare
|
Rebased and I think ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a command is routed through bash because it's too long, the fact it's meant to be piped to NUL is forgotten. Ensure the bash command is piped to >/dev/null (with the slightly tedious recovery of the script needed if the command fails).
#68 needs to be merged first, because it corrects a magic number in this PR