fix: executing processes #8409
Merged
fix: executing processes #8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix__action_runners_shouldn_t_be_cancelled_by_watch_mode
branch
from
e7d985a
to
05e0bfb
Compare
rgrinberg
changed the title
Alizter
approved these changes
Aug 16, 2023
|
Adding @gridbugs as a reviewer as well given that this is relevant to |
gridbugs
approved these changes
Aug 18, 2023
dkalinichenko-js
approved these changes
Aug 18, 2023
rgrinberg
force-pushed
the
ps/rr/fix__action_runners_shouldn_t_be_cancelled_by_watch_mode
branch
from
05e0bfb
to
5fedf34
Compare
* in dune exec, the running process is already being killed by the polling loop. There's no need to do it twice. * the action runner process shouldn't be restarted when the input changes Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: c514d0be-ca45-461e-ad68-8605c686d380 -->
rgrinberg
force-pushed
the
ps/rr/fix__action_runners_shouldn_t_be_cancelled_by_watch_mode
branch
from
5fedf34
to
e32fa93
Compare
rgrinberg
deleted the
ps/rr/fix__action_runners_shouldn_t_be_cancelled_by_watch_mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in dune exec, the running process is already being killed by the
polling loop. There's no need to do it twice.
the action runner process shouldn't be restarted when the input
changes