Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable background digests on Windows #8243

Merged
merged 2 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ Unreleased
- Fix permission errors when `sendfile` is not available (#8234, fixes #8120,
@emillon)

- Disable background digests on Windows. This prevents an issue where
unremovable files would make dune crash when the shared cache is enabled.
(#8243, fixes #8228, @emillon)

3.9.1 (2023-07-06)
------------------

Expand Down
5 changes: 4 additions & 1 deletion src/dune_config/config.ml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ let background_digests =
let t =
{ name = "background_digests"
; of_string = Toggle.of_string
; value = background_default
; value =
(match Platform.OS.value with
| Linux -> `Enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you disable it on Mac and the rest of the unixes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I remember that we have that fork bug as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can introduce a Toggle.and_ to express that as background_default and not windows if you think it's more explicit.

| _ -> `Disabled)
}
in
register t;
Expand Down