Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: use posix_spawn on macos #8090

Merged
merged 1 commit into from
Aug 8, 2023
Merged

feature: use posix_spawn on macos #8090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/changes/8090.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Use `posix_spawn` instead of `fork` on MacOS. This gives us a performance
boost and allows us to re-enable thread. (#8090, @rgrinberg)
2 changes: 1 addition & 1 deletion src/dune_config/config.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ let copy_file =

let background_default =
match Platform.OS.value with
| Linux | Windows -> `Enabled
| Linux | Windows | Darwin -> `Enabled
| _ -> `Disabled
;;

Expand Down
Loading
Loading