fix: sendfile: fall back to portable copy #8049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Jun 26, 2023
Fixes ocaml#8041 Signed-off-by: Etienne Millon <[email protected]>
This was referenced Jun 27, 2023
Closed
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jun 27, 2023
Fixes ocaml#8041 Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jun 27, 2023
Fixes ocaml#8041 Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jun 27, 2023
Fixes ocaml#8041 Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
that referenced
this pull request
Jun 27, 2023
* test: add repro for #8041 (#8048) Signed-off-by: Etienne Millon <[email protected]> * fix: sendfile: fall back to portable copy (#8049) Fixes #8041 Signed-off-by: Etienne Millon <[email protected]> --------- Signed-off-by: Etienne Millon <[email protected]>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jun 27, 2023
CHANGES: - Fix deadlock on Windows (ocaml/dune#8044, @nojb) - When using `sendfile` to copy files on Linux, fall back to the portable version if it fails at runtime for some reason (NFS, etc). (ocaml/dune#8049, fixes ocaml/dune#8041, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8041.
When using
sendfileto copy files on Linux, fall back to the portable version if it fails at runtime for some reason (NFS, etc).