-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coq): pass correct flags to coqdep when building boot libs #7942
fix(coq): pass correct flags to coqdep when building boot libs #7942
Conversation
Signed-off-by: Ali Caglayan <[email protected]>
8ba3a37
to
3c4192d
Compare
Thanks a lot @Alizter , will review (and hopefully merge) ASAP. |
Why not? Patch seems broken? Didn't look closely at the test cases but maybe this is due to the logic being a bit more subtle now. Even in earlier versions of the build language, we do detect the boot library that is in Does it make sense? |
@ejgallego feel free to takeover. It seemed to work for me. |
I see CI / Coq test suite is broken, isn't it? |
@ejgallego only updating thr new flags. |
If this is the right fix, please resurrect. |
I see a truly broken test-case and a few suspicious things, don't you? It seems that combining |
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <[email protected]>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <[email protected]>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <[email protected]>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <[email protected]>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <[email protected]>
fix #7909
I've tested the reproduction in #7909 and it works. I will not add a test for this.