Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt read from closed fd in dune_rpc_lwt #7581

Merged

Commits on Apr 21, 2023

  1. Don't attempt read from closed fd in dune_rpc_lwt

    This fixes a bug where RPC clients built with dune_rpc_lwt would crash
    while disconnecting as they attempted to read from a channel whose
    underlying file descriptor had been closed.
    
    Also updates the dune-rpc-lwt expect test to expect the text "success"
    to be printed by the client after its connection is closed. It wasn't
    being printed prior to this change.
    
    Signed-off-by: Stephen Sherratt <[email protected]>
    gridbugs committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    710533a View commit details
    Browse the repository at this point in the history