Only enable package in short-form rules on dune lang 3.8+
#7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ocaml#7471 Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Etienne Millon <[email protected]>
emillon
force-pushed
the
versioned-package-support
branch
from
ef44089
to
65cca77
Compare
emillon
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks @Leonidas-from-XIV . I refactored the implementation. so that the atom is not duplicated into the check. Does that this right to you?
|
Ah yes, that's a much nicer implementation indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7471, as discussed in #7461 to only allow the #7445 feature on dune-lang 3.8.
This fixes the issue that #7445 by itself fixes a language quirk that is only fixed in 3.8, but without actually requiring dune-lang 3.8. It revises the previous test that uses an older dune-lang to fail.