Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] backport #7445 (Allow package in any location in rule) #7461

Closed
wants to merge 1 commit into from
Closed

[3.7] backport #7445 (Allow package in any location in rule) #7461

wants to merge 1 commit into from

Commits on Mar 31, 2023

  1. fix: Allow package in any location in rule (ocaml#7445) 

    While fixing the package associations in ocaml/opam#5496 I realized that the package stanza is only accepted when it is at the end of the rule stanza.

* Add test that `packages` needs to be last, or it will be rejected

    File "dune", line 12, characters 3-10:
    12 |   (package a)
            ^^^^^^^
    Error: Unknown action or rule field.
    [1]

Signed-off-by: Marek Kubica <[email protected]>
Co-authored-by: Etienne Millon <[email protected]>
    @Leonidas-from-XIV @emillon
    Leonidas-from-XIV and emillon committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    85369a3 View commit details
    Browse the repository at this point in the history