Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boot): fix env vars when finding out concurrency #7272

Merged
merged 1 commit into from
Mar 11, 2023
Merged

fix(boot): fix env vars when finding out concurrency #7272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Unreleased
----------

- Bootstrap: correctly detect the number of processors by allowing `nproc` to be
looked up in `$PATH` (#7272, @Alizter)

- Speed up file copying on macos by using `clonefile` when available
(@rgrinberg, #7210)

Expand Down
2 changes: 1 addition & 1 deletion boot/duneboot.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ let exe = if Sys.win32 then ".exe" else ""

let concurrency =
let try_run_and_capture_line cmd =
let ic, oc, ec = Unix.open_process_full cmd [||] in
let ic, oc, ec = Unix.open_process_full cmd (Unix.environment ()) in
let line =
match input_line ic with
| s -> Some s
Expand Down