Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: assume Cmdliner.Arg.conv is abstract #6609

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Nov 30, 2022

Cmdliner.Arg.conv happens to be a pair of parser and printer but is marked as to be made abstract. Actually the work on completion requires making it abstract and modify it. So this PR switches to using just the public API.

`Cmdliner.Arg.conv` happens to be a pair of `parser` and `printer` but
is marked as to be made abstract. Actually the work on completion
requires making it abstract and modify it. So this PR switches to using
just the public API.

Signed-off-by: Etienne Millon <[email protected]>
@emillon emillon merged commit a8bd126 into ocaml:main Nov 30, 2022
@emillon emillon deleted the cmdliner-conv-abstract branch November 30, 2022 14:42
moyodiallo pushed a commit to moyodiallo/dune that referenced this pull request Dec 2, 2022
`Cmdliner.Arg.conv` happens to be a pair of `parser` and `printer` but
is marked as to be made abstract. Actually the work on completion
requires making it abstract and modify it. So this PR switches to using
just the public API.

Signed-off-by: Etienne Millon <[email protected]>
jchavarri added a commit to jchavarri/dune that referenced this pull request Dec 5, 2022
* main: (54 commits)
  doc: how we write `to_dyn` and `equal` (ocaml#6621)
  test(cache): test output of man pages
  test: dune utop for (subdir ..) (ocaml#6629)
  refactor: improve style of utop rules (ocaml#6628)
  test: depend on utop (ocaml#6627)
  refactor(stdune): Add Appendable_list.cons (ocaml#6624)
  doc: tighten wording in README.md
  test: add a repro case for ocaml#6607 (ocaml#6612)
  doc: cleanup status badges in README.md (ocaml#6618)
  doc(README): rewrap paragraphs and cleanup links
  coq: more resilient config query
  fix: link time code gen (ocaml#6606)
  fix(melange): run melc ppx with merlin (ocaml#6476)
  feature(melange): add compile_flags (ocaml#6569)
  refactor: move `modules: Modules.t` from `Dune_package.Lib` to `Lib_info` (ocaml#6605)
  Set CLICOLOR_FORCE=0 (ocaml#6608)
  fix: declare deps for ccomp detection (ocaml#6610)
  refactor: assume Cmdliner.Arg.conv is abstract (ocaml#6609)
  refactor: gen_rules pattern matching (ocaml#6604)
  Add CI for MSVC using dkml-workflows (ocaml#6540)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants