Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check alias and dependency cycles #5892

Merged
merged 3 commits into from
Jun 23, 2022
Merged

check alias and dependency cycles #5892

merged 3 commits into from
Jun 23, 2022

Commits on Jun 20, 2022

  1. test: move check alias tests to own dir 

    Signed-off-by: Rudi Grinberg <[email protected]>

ps-id: 2FDB8957-212D-4FFF-8097-402CBC56F955
    @rgrinberg
    rgrinberg committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    3c12d8a View commit details
    Browse the repository at this point in the history

  2. test: demonstrate bug with check alias 

    The check alias doesn't fail when cycles are introduced in some cases

Signed-off-by: Rudi Grinberg <[email protected]>
    @rgrinberg
    rgrinberg committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    79db8a2 View commit details
    Browse the repository at this point in the history

  3. fix(rules): @check & cycles 

    building the check alias should make sure there are no cycles

Signed-off-by: Rudi Grinberg <[email protected]>
    @rgrinberg
    rgrinberg committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    d9e40ae View commit details
    Browse the repository at this point in the history