Remove warning about empty packages pre 3.0 #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremie Dimino <[email protected]>
ghost
requested a review
from 
|
Most of it is a revert of the changes to the testsuite in #4861. Merging as the testsuite is currently broken. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testsuite is broken following #4867. Also, I didn't noticed but some tests ended being updated in a way that they didn't test what they were originally testing.
I tried to update tests but it was a pain so I removed the warning pre 3.0 and also set
allow_emptytotruefor packages defined by an opam file rather than a package stanza. This makes the behaviour more conservative.However, we still need a cram test for #4867.