Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass -I <stdlib-dir> #488

Merged
2 commits merged into from
Feb 6, 2018
Merged

Do not pass -I <stdlib-dir> #488

2 commits merged into from
Feb 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2018

Make sure we don't pass -I <stdlib-dir> to the compiler. This path is always implicitly added and passing it doesn't play nice with #472

@ghost ghost requested a review from rgrinberg February 6, 2018 07:46
@ghost
Copy link
Author

ghost commented Feb 6, 2018

This is trivial so merging it now

@ghost ghost merged commit d4c9eb6 into master Feb 6, 2018
@rgrinberg
Copy link
Member

I wonder if this fixes that weird issue with Camomile and uchar as well

@ghost
Copy link
Author

ghost commented Feb 6, 2018

It's likely, it was the issue in #472 and it's fixed by this PR

@ghost ghost deleted the filter-stdlib-dir branch February 7, 2018 14:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants