Fix temp path creation in Dune cache #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
requested changes
Mar 26, 2021
|
A CHAGNES entry would also be nice here. Since this fix is important, it would be nice to make a point release that includes it as well. |
snowleopard
force-pushed
the
fix-tmp-dir-in-cache
branch
from
73cdcac to
8056013
Compare
@rgrinberg Agreed, done! |
rgrinberg
approved these changes
Mar 26, 2021
|
@rgrinberg Apparently Thanks for the review! |
Signed-off-by: Andrey Mokhov <[email protected]>
Signed-off-by: Andrey Mokhov <[email protected]>
Signed-off-by: Andrey Mokhov <[email protected]>
Signed-off-by: Andrey Mokhov <[email protected]>
snowleopard
force-pushed
the
fix-tmp-dir-in-cache
branch
from
c89a1dc to
3289a92
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Mar 29, 2021
…ne-action-plugin, dune-private-libs and dune-glob (2.8.5) CHANGES: - Fixed absence of executable bit for installed `.cmxs` (ocaml/dune#4149, fixes ocaml/dune#4148, @bobot) - Fix a race in Dune cache. It was particularly easy to hit this race when using the cache on Windows (ocaml/dune#4406, fixes ocaml/dune#4167, @snowleopard)
rgrinberg
pushed a commit
that referenced
this pull request
Mar 29, 2021
Fix a race in Dune cache. It was particularly easy to hit this race when using the cache on Windows, see #4167. Signed-off-by: Andrey Mokhov <[email protected]> Signed-off-by: Rudi Grinberg <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4167.