Expose the promote mode #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
samoht
reviewed
Jan 23, 2018
CHANGES.md
Outdated
| + `(mode fallback)` replaces `(fallback)` | ||
| + `(mode promote)` means that targets are copied to the source tree | ||
| after the rule has completed | ||
| + `(mode promote-until-clea)` is the same as `(mode promote)` except |
rgrinberg
reviewed
Jan 25, 2018
| | true, Some _ -> | ||
| Error "Cannot use both (fallback) and (mode ...) at the same time.\n\ | ||
| (fallback) is the same as (mode fallback), \ | ||
| please use the latter in new code." |
There was a problem hiding this comment.
Will (fallback) be removed in 1.0?
There was a problem hiding this comment.
yes, we'll get the upgrade tool to translate it to (mode fallback)
rgrinberg
approved these changes
Jan 25, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the promote mode that was internally implemented in #370.
(mode ...)fieldThis PR adds a
(mode <mode>)field toruleandmenhirstanzas. The following modes are allowed:standard, the defaultfallback, replaces(fallback)promote, after the rule has been executed copy the targets to the source treepromote-until-clean, same aspromoteexcept thatjbuilder cleandelete the files copied to the source treeocamlyaccandocamllexextensionsTo allow using a different mode with
ocamlyaccandocamllexstanzas, an alternative syntax is added:--ignore-promoted-rulesargumentThe
--ignore-promoted-rulesargument is added to make jbuilder filter out rules with(mode promote). It is automatically set by-p/--for-release-of-packages, to cut down dependencies during releases.