Allow [package] on cram stanza #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adhoc solution mentioned in #3792 (comment) Not great, but the lack of this field really hurts the usability of cram tests. |
ghost
reviewed
Jan 12, 2021
|
Looks good to merge otherwise. |
rgrinberg
force-pushed
the
cram-package
branch
from
9b1db37 to
57e5e6b
Compare
ghost
reviewed
Jan 13, 2021
the [package] field will attach the tests of this cram stanza to the specified package Signed-off-by: Rudi Grinberg <[email protected]>
The plugin stanza did not specify the stanza name correctly. A [~stanza] label is added to this argument to avoid mistakes like this in the future. Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
cram-package
branch
from
400b881 to
257d44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the [package] field will attach the tests of this cram stanza to the
specified package
Fixes #3792