Do not use the transitive closure in generated META files #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
simplify-meta-generation
branch
from
0f4adda
to
8d2bbd9
Compare
rgrinberg
reviewed
Jan 12, 2018
src/lib_db.ml
Outdated
| | x -> Inl [x] | ||
| | exception e -> | ||
| (* Call [find] again to get a proper backtrace *) | ||
| Inr { fail = fun () -> ignore (find_exn t ~from:dir name : Lib.t); raise e } |
There was a problem hiding this comment.
Would you mind explaining this trick a bit? How does calling find_exn again get us a proper back trace? Isn't it going to just raise and we won't re-raise e?
There was a problem hiding this comment.
yes, that's the expectation. In fact we could just replace the raise e by assert false. By calling find_exn, we get a more precise backtrace. For instance it might start in findlib.ml
There was a problem hiding this comment.
OK, I think doing assert false will be a little nicer since we won't even have to bind e in the pattern match.
rgrinberg
reviewed
Jan 12, 2018
| List.map (String_set.elements required) ~f:(find_exn t ~from:dir) | ||
| with | ||
| | l -> Some l | ||
| | exception _ -> None) |
There was a problem hiding this comment.
Unrelated: Maybe we should just add Option.try_with I see that we do this idiom in a few places already.
rgrinberg
approved these changes
Jan 12, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in META files jbuilder uses the transitive closure in
requiresandppx_runtime_depsvariables. I can't remember why I did that but it seems simpler not to do that.The generated META files are smaller, It simplifies the code and in any case it's likely that using the transitive closure won't be compatible with library variants.