Use /Fo instead of -o when invoking CL #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
commented
Dec 8, 2017
src/arg_spec.ml
Outdated
| @@ -6,6 +6,7 @@ type 'a t = | |||
| | A of string | |||
| | As of string list | |||
| | S of 'a t list | |||
| | Tight of 'a t list | |||
There was a problem hiding this comment.
I debated just calling this T 🙂 Another option would be to make it a parameter of S (which would have stopped the initial risk of not gathering dependency information in an earlier version) but would be a much more invasive change.
There was a problem hiding this comment.
What about Concat of string (* separator *) * 'a t list?
|
Thanks for the review, @diml (sorry for the slowness pushing the change) |
The -o option in the Microsoft C Compiler is deprecated (and has been for a very long time). The warning is tedious, so use /Fo instead. The only problem with this is that "-o foo.obj" must become "/Fofoo.obj" with no space, which requires a little support in Arg_spec. Signed-off-by: David Allsopp <[email protected]>
ghost
approved these changes
Jan 22, 2018
No worries :) Patch looks good |
|
Ta! Travis has such a backlog with macOS at the moment (they've had severe trouble with their whole Mac infrastructure for a few days) that I'm just ignoring Mac CI for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-ooption in the Microsoft C Compiler is deprecated (and has been for a very long time). The warning is tedious, so use /Fo instead. The only problem with this is that-o foo.objmust become/Fofoo.objwith no space, which requires a little support inArg_spec.This appears principally when compiling C++ sources, as these aren't compiled by OCaml (which already handles these differences).
Still to do is suppressing the tedious display of the source file being compiled (see ocaml/ocaml#407) but that hasn't (yet) been annoying me as much as the deprecation warning!