Refactor jbuilder exec path handling #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need for runcwd as initial_cwd is already defined somewhere. Add Filename.analyze_program_name function to make the clearer.
|
Does that fix #326 or is it an effectless factorization? |
|
The bug still remains so it's a pure factorization
…On Tue, Nov 14, 2017, 6:34 PM François Bobot ***@***.***> wrote:
Does that fix !326 or is it an effectless factorization?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIe-x9XgEtHd7QEZC6s2-O7pAgo_SVBks5s2WyegaJpZM4QcKoJ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for runcwd as initial_cwd is already defined somewhere. Add
Filename.analyze_program_name function to make the clearer.
This is a patch emailed to me by diml. Though I offered the commit message.