Print "Leaving directory '...'" in addition to "Entering directory ..." #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpitclaudel
force-pushed
the
cpitclaudel_138
branch
from
56680dc
to
603d001
Compare
The "Entering ..." message was introduced in 157e4d6. Adding a matching "Leaving directory "..."' message helps when dune is invoked in sequence with other programs: otherwise, editors use dune's root to interpret path printed by programs executed after dune (instead of the original working directory). Discussed in ocaml#138. Signed-off-by: Clément Pit-Claudel <[email protected]>
cpitclaudel
force-pushed
the
cpitclaudel_138
branch
from
603d001
to
ae30bf7
Compare
|
Btw, I wasn't too sure what indentation style to use. I tried running ocp-indent on that file, but it reformatted a lot more than just the section I touched, so I didn't do that in the end. |
|
We are using ocamlformat to format the code. You can either setup your editor to automatically format ml files, or you can run |
|
I was just looking at the tests. When running some commands, it seems that some messages are printed after the |
|
Revived in #3072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Entering ...message was introduced in 157e4d6. Adding a matchingLeaving directory ...message helps when dune is invoked in sequence withother programs: otherwise, editors use dune's root to interpret path printed by
programs executed after dune (instead of the original working directory).
Discussed in #138.