Add support for locks in rules #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht
reviewed
Sep 23, 2017
CHANGES.md
Outdated
| @@ -16,6 +16,8 @@ next | |||
| current directory. This allows Emacs and Vim to know where relative | |||
| filenames should be interpreted from. Fixes #138 | |||
|
|
|||
| - Add support for locks in actions, for flaky tests | |||
|
|
|||
There was a problem hiding this comment.
hey, my tests are not flacky :p they just happen to use an OS resources (e.g. a port) and they would like to have exclusive access to it :-)
|
That looks great, thanks! |
This is to allow users define more complicated tests without having to resort to -j1.
ghost
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @samoht
This PR allows users to specify that some action must be executed while holding some locks:
In some cases, people want to make sure that some non-conventional tests don't run in parallel, and this PR allows to do that without having to resort to
-j1.Locks could be implemented in the action language, or even outside of jbuilder by taking a lock file. However having them in jbuilder allows to avoid monopolizing a job just for waiting on a lock.