Remove readonly attribute on Windows before unlink #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
force-pushed
the
win-unlink
branch
3 times, most recently
from
897a57d
to
395872a
Compare
|
What's the issue with this CI failure? Is that we're waiting for to merge this? |
The legacy DOS readonly attribute is a tedious difference on Windows, because a user may have permission to delete a file, but unlink fails because the attribute is set. Signed-off-by: David Allsopp <[email protected]>
|
Will merge assuming this still passes CI (which it should) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy DOS readonly attribute is a tedious difference on Windows, because a user may have permission to delete a file, but unlink fails because the attribute is set.