Move status line generator global state from Console to Scheduler #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jul 9, 2019
bobot
force-pushed
the
bobot/simplify_console_handling
branch
from
5606d47
to
1bd4055
Compare
Signed-off-by: François Bobot <[email protected]>
bobot
force-pushed
the
bobot/simplify_console_handling
branch
from
1bd4055
to
b56ca78
Compare
|
I was also wondering the same thing, so the simplification is done. Is it a problem to change an API in stddune? |
Signed-off-by: François Bobot <[email protected]>
Otherwise hiding then printing user message would show back the old status line Signed-off-by: François Bobot <[email protected]>
bobot
force-pushed
the
bobot/simplify_console_handling
branch
from
b56ca78
to
cde9860
Compare
ghost
approved these changes
Jul 9, 2019
|
Cool :) Changing stdune is fine. We are the only user of it so we can do whatever we want with it. |
|
@bobot ping. I believe you can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2374 it seems easier to keep the status line generator out of the global console so that the line for the scheduler and for file tree are separated and not mixed.