Better behavior when the targets of a rule already exist in the source tree #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if the targets of a rule are already present in the source tree, jbuilder ignores the rule. This is convenient for configure scripts: one can have the configure script generate a configuration file based on command line arguments supplied by the user and a rule to generate a default one. However, it is error prone in other cases. Especially when they are left-over files from a previous build system in the source tree.
This PR changes Jbuilder to emit a warning when such a case happens. The user now has to add
(fallback)
to the rule to specify that the rule only applies when the targets do not already exist in the source tree. For instance:Additionally, it is an error if only a subset of the targets are present.
This PR fixes #187 and #148.