Use greedy extension for -intf-suffix #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
commented
Jul 14, 2017
src/import.ml
Outdated
| match split_extension fn with | ||
| | _, "" -> "" | ||
| | (f, e) when Filename.extension f = "" -> e | ||
| | (f, e) -> greedy_extension f ^ "." ^ e |
There was a problem hiding this comment.
This is the original patch, but should I just use String.lsplit2 here?
Since reason sources are named as .{re,rei}.{ml,mli}
rgrinberg
force-pushed
the
reason-ext-fix
branch
from
106caf1
to
c82a5cb
Compare
|
Superseded by 0d1a3b7 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since reason sources are named as .{re,rei}.{ml,mli}
Fix #184