Fix interpretation of / in META files #1889
Conversation
|
I checked manually that it fixes the issue. |
|
Thanks! I've pinned this PR and tested locally: problem solved. |
CHANGES.md
Outdated
| ------------------ | ||
|
|
||
| - Fix interpretation of `META` files containing archives with `/` in | ||
| the filename. This was causing llvm to be unusable with dune (#1889, |
There was a problem hiding this comment.
It might be more helpful to people reading the changelog if a less specific description was given. I don't think that llvm is so special, wouldn't the same issue arise for any lib with sublibs?
There was a problem hiding this comment.
Before dune, all sublibs were usually installed in the main directory since that was the easiest thing to do. Sublibs installed in subdirs generally have a directory field (that's what dune does for instance) and since filenames are relative to that directory, filenames still don't contain slashes.
So llvm is probably one of a very small set of projects to be affected, so it seems worth mentioning to me. I added "for instance" to make it clear it's just an example
There was a problem hiding this comment.
I see, thanks for the explanation. (Maybe there is too much flexibility somewhere...)
Fix #1885 Signed-off-by: Jeremie Dimino <[email protected]>
ghost
merged commit 
Fix #1885 Signed-off-by: Jeremie Dimino <[email protected]>
CHANGES: - Fix interpretation of `META` files containing archives with `/` in the filename. For instance, this was causing llvm to be unusable with dune (ocaml/dune#1889, fix ocaml/dune#1885, @diml) - Make errors about menhir stanzas be located (ocaml/dune#1881, fix ocaml/dune#1876, @diml)
Fixes #1885