fix: correct expander for cram stanzas #10185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix__correct_expander_for_cram_stanzas
branch
5 times, most recently
from
b3611fd
to
611d164
Compare
We should use the expander where the stanza is defined, rather than the expander of the test. Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 99bf8567-5f12-47e1-bf82-0def504fea7d -->
rgrinberg
force-pushed
the
ps/rr/fix__correct_expander_for_cram_stanzas
branch
from
611d164
to
0a9a2c9
Compare
emillon
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the expander where the stanza is defined, rather than the
expander of the test.
Signed-off-by: Rudi Grinberg [email protected]