Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Shave off dune-site specific things from the opam file generation #4849

Closed
kit-ty-kate opened this issue Aug 5, 2021 · 0 comments · Fixed by #4861
Closed
Labels
accepted accepted proposals feature-request

Comments

@kit-ty-kate
Copy link
Member

Desired Behavior

It would be nice to only have the "--promote-install-files" "false" argument and subsequent dune install ... lines in the generated opam files only if dune-site is enabled.

Example

$ cat dune-project
(lang dune 3.0)
(using dune_site 0.1)
(generate_opam_files true)
[...]
$ cat pkg.opam
[...]
  build: [
    ["dune" "subst"] {dev}
    [
      "dune"
      "build"
      "-p"
      name
      "-j"
      jobs
      "--promote-install-files"
      "false"
      "@install"
      "@runtest" {with-test}
      "@doc" {with-doc}
    ]
    ["dune" "install" "-p" name "--create-install-files" name]
  ]
[...]
$ cat dune-project
(lang dune 3.0)
(generate_opam_files true)
[...]
$ cat pkg.opam
[...]
  build: [
    ["dune" "subst"] {dev}
    [
      "dune"
      "build"
      "-p"
      name
      "-j"
      jobs
      "@install"
      "@runtest" {with-test}
      "@doc" {with-doc}
    ]
  ]
[...]
@bobot bobot added accepted accepted proposals feature-request labels Aug 16, 2021
bobot added a commit that referenced this issue Aug 18, 2021
bobot added a commit that referenced this issue Aug 18, 2021
bobot added a commit that referenced this issue Aug 18, 2021
bobot added a commit that referenced this issue Aug 18, 2021
bobot added a commit that referenced this issue Aug 20, 2021
bobot added a commit that referenced this issue Aug 20, 2021
bobot added a commit that referenced this issue Nov 17, 2021
bobot added a commit that referenced this issue Nov 18, 2021
bobot added a commit that referenced this issue Nov 20, 2021
bobot added a commit that referenced this issue Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted proposals feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants