Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLG -ppx directive missing in .merlin #1946

Closed
Khady opened this issue Mar 14, 2019 · 1 comment · Fixed by ocaml/opam-repository#13860
Closed

FLG -ppx directive missing in .merlin #1946

Khady opened this issue Mar 14, 2019 · 1 comment · Fixed by ocaml/opam-repository#13860

Comments

@Khady
Copy link
Contributor

Khady commented Mar 14, 2019

When a dune file contains two library/executable with different ppx, the .merlin file generated for this directory doesn't contain a FLG -ppx line.

I created a repository with a simple case to reproduce https://github.com/Khady/dune-merlin-ppx

@Khady
Copy link
Contributor Author

Khady commented Mar 14, 2019

Kind of a duplicate of #334 #230 #1212

rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Mar 14, 2019
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Mar 14, 2019
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Mar 18, 2019
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Apr 9, 2019
CHANGES:

- Warn when generated `.merlin` does not reflect the preprocessing
  specification. This occurs when multiple stanzas in the same directory use
  different preprocessing specifications. This warning can now be disabled with
  `allow_approx_merlin` (ocaml/dune#1947, fix ocaml/dune#1946, @rgrinberg)

- Watch mode: display "Success" in green and "Had errors" in red (ocaml/dune#1956,
  @emillon)

- Fix glob dependencies on installed directories (ocaml/dune#1965, @rgrinberg)

- Add support for library variants and default implementations. (ocaml/dune#1900,
  @TheLortex)

- Add experimental `$ dune init` command. This command is used to create or
  update project boilerplate. (ocaml/dune#1448, fixes ocaml/dune#159, @shonfeder)

- Experimental Coq support (fix ocaml/dune#1466, @ejgallego)

- Install .cmi files of private modules in a `.private` directory (ocaml/dune#1983, fix
  ocaml/dune#1973 @rgrinberg)

- Fix `dune subst` attempting to substitute on directories. (ocaml/dune#2000, fix ocaml/dune#1997,
  @rgrinberg)

- Do not list private modules in the generated index. (ocaml/dune#2009, fix ocaml/dune#2008,
  @rgrinberg)

- Warn instead of failing if an opam file fails to parse. This opam file can
  still be used to define scope. (ocaml/dune#2023, @rgrinberg)

- Do not crash if unable to read a directory when traversing to find root
  (ocaml/dune#2024, @rgrinberg)

- Do not exit dune if some source directories are unreadable. Instead, warn the
  user that such directories need to be ignored (ocaml/dune#2004, fix ocaml/dune#310, @rgrinberg)

- Fix nested `(binaries ..)` fields in the `env` stanza. Previously, parent
  `binaries` fields would be ignored, but instead they should be combined.
  (ocaml/dune#2029, @rgrinberg)

- Allow "." in `c_names` and `cxx_names` (ocaml/dune#2036, fix ocaml/dune#2033, @rgrinberg)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant