Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault when attempting to compile Pyre with dune 1.8.0 #1918

Closed
sinancepel opened this issue Mar 7, 2019 · 3 comments · Fixed by ocaml/opam-repository#13620
Closed

Segfault when attempting to compile Pyre with dune 1.8.0 #1918

sinancepel opened this issue Mar 7, 2019 · 3 comments · Fixed by ocaml/opam-repository#13620

Comments

@sinancepel
Copy link
Contributor

We've been using Dune to build Pyre (https://github.com/facebook/pyre-check) for a while now. After switching to dune 1.8.0 from dune 1.2.1, I'm seeing crashes of the form Error: exception Invalid_argument("atom '' cannot be in dune syntax").

Any pointers on how I could debug this and support later Dune versions? I tried running it with dune build @install --verbose and with the various debug flags, but none seemed to point me at the right file with the syntax error.

To repro:

$ dune --version
1.8.0
$ git clone [email protected]:facebook/pyre-check.git
$ cd pyre-check
$ ./scripts/setup.sh
@rgrinberg
Copy link
Member

rgrinberg commented Mar 8, 2019 •
edited
Loading

I fixed it in #1919. Please test it out. It seems like your version is empty by the way.

rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Mar 8, 2019
@rgrinberg
[new release] dune (1.8.1)
5b31015 
CHANGES:

- Correctly write `dune-package` when version is empty string (ocaml/dune#1919, fix ocaml/dune#1918,
  @rgrinberg)
@rgrinberg rgrinberg mentioned this issue Mar 8, 2019
Merged
@rgrinberg
Copy link
Member

Fixed in 1.8.1

@sinancepel
Copy link
Contributor Author

Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new release] dune (1.8.1) rgrinberg/opam-repository
2 participants
@rgrinberg @sinancepel