bugfix: Allow package in any location in rule

Signed-off-by: Marek Kubica <[email protected]>
ocaml · Mar 29, 2023 · 028f47f · 028f47f
1 parent 3930ad5
commit 028f47f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -86,6 +86,9 @@ Unreleased
 - Support `(link_flags ...)` in `(cinaps ...)` stanza. (#7423, fixes #7416,
   @nojb)
 
+- Allow `(package ...)` in any position within `(rule ...)` stanza (#7445,
+  @Leonidas-from-XIV)
+
 3.7.0 (2023-02-17)
 ------------------
 

diff --git a/src/dune_rules/dune_file.ml b/src/dune_rules/dune_file.ml
@@ -1728,6 +1728,7 @@ module Rule = struct
       ; ("aliases", Field)
       ; ("alias", Field)
       ; ("enabled_if", Field)
+      ; ("package", Field)
       ]
 
   let short_form =

diff --git a/test/blackbox-tests/test-cases/package-rule.t/run.t b/test/blackbox-tests/test-cases/package-rule.t/run.t
@@ -1,8 +1,5 @@
 When --only-packages is passed, it runs
 
   $ dune build --only-packages a @runtest
-  File "dune", line 12, characters 3-10:
-  12 |   (package a)
-          ^^^^^^^
-  Error: Unknown action or rule field.
-  [1]
+  A
+  A