Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new set of exercises + Organising corpus. #37

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

hernoufM
Copy link
Contributor

@hernoufM hernoufM commented Jun 15, 2023

This PR brings significant changes to the content and organization of the corpus. The following sets of exercises have been added:

  • 59 exercises by Simão Melo de Sousa.
  • 21 exercises by Hugo Férée.

These exercises are aimed at relatively beginners in OCaml programming who wish to practice and solidify their understanding. These exercises can also serve as a good challenge for experienced users in OCaml programming. While they are primarily designed for beginners to practice and reinforce their understanding, they may still offer interesting problems and opportunities for more experienced users to further enhance their skills and explore advanced concepts.

Regarding the changes in organization, we would like to highlight the following:

  • All new and existing exercises are organized into a large directed graph using the meta field backward_exercises.
  • The focus field has been populated, which now contains several topics that a specific exercise helps to sharpen.

This PR is closely related to a PR created for the Learn-ocaml platform in order to better visualize the new organization.

In conclusion, we would like to express our heartfelt gratitude to the contributors, Hugo Férée (@hferee) and Simão Melo de Sousa (@smdsousa), for generously providing us with their valuable exercises. These contributions will greatly enrich the corpus and provide a wealth of learning opportunities for beginners and experienced users alike in the field of OCaml programming.

@hferee
Copy link

hferee commented Jun 16, 2023

First, thank you for this integration work!

In particular, you had to translate all the exercise statements in english ; but there are still many french artifacts remaining, which makes for a weird mix of languages.
This includes:

  • variable names (e.g. "bissextile")
  • placeholders ("remplacez-moi")
  • custom error messages (in some test.ml)

This is certainly quite a lot more work to fix though.

@hernoufM
Copy link
Contributor Author

Hello, @hferee.
Thanks for your feedback, and again, for such a major contribution!
You are absolutely right, that it makes weird to have some french artifacts remaining within exercises.
We tried to highlight and translate those parts of the code without translation of which an English-speaking user simply could not complete the exercises. A thorough translation of all variables and function names definitely makes sense, but at the same time it adds the risk that some part of the exercise has not been changed and will lead to an error or incorrect interpretation of the result. Despite all this, a full translation will most likely be reviewed and made in the near future.

@hernoufM hernoufM marked this pull request as draft June 29, 2023 11:59
@yurug yurug self-assigned this Jul 10, 2023
@hernoufM hernoufM marked this pull request as ready for review July 24, 2023 15:02
- stuff not allowed in modules but allowed in toplevel:
  * function with weak types
  * type redefinition (this was an error!)

- functions that were called `sample_xxx` while it wasn't a definition of a
  sampler that should be registered, and there was no `xxx` type.
@AltGr AltGr merged commit 5b94c8c into ocaml-sf:master Oct 30, 2023
2 checks passed
@erikmd
Copy link
Member

erikmd commented Nov 3, 2023

Thanks a lot @hernoufM, @hferee, @smdsousa and @AltGr 👍👍

Given we don't have an automatic deployment pipeline yet (ocaml-sf/learn-ocaml#507),
FYI I will now take care of deploying learn-ocaml-corpus' master to https://ocaml-sf.org/learn-ocaml-public/ with the last learn-ocaml release.

@erikmd
Copy link
Member

erikmd commented Nov 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants