Simplify 502 migration location check test #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
requested review from
ceastlund,
panglesd,
patricoferris and
pitag-ha
as code owners
NathanReb
added
the
no changelog
|
This is based on top of #506 |
NathanReb
force-pushed
the
simplify-502-migration-location-check-test
branch
from
27a70b5
to
3411bbe
Compare
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
simplify-502-migration-location-check-test
branch
from
3411bbe
to
3b51e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test can be greatly simplified by using the driver's native location check instead!