Add Warnings.Errors argument for < 4.06 compatibility #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarty
changed the title
jberdine
reviewed
Dec 16, 2017
src/Translation_unit.ml
Outdated
| @@ -130,7 +130,7 @@ let parse_print (XUnit xunit) (conf: Conf.t) iname ifile ic ofile = | |||
| in | |||
| let source = In_channel.with_file ifile ~f:In_channel.input_all in | |||
| try parse_print_ 1 source ifile ic with | |||
There was a problem hiding this comment.
Could you change try to try[@warning "-28"] to suppress the warning when building with 4.06.
It would also be good to reference ocaml-ppx/ocaml-migrate-parsetree#34 so that if/when the type of exceptions is migrated by migrate-parsetree, then we can update and remove the warning suppression.
There was a problem hiding this comment.
Definitely - I'll update this PR with the annotation and reference to the omp issue.
|
And thanks! Nice catch. |
|
@jberdine Updated to suppress warning 28 with a comment pointing to ocaml-ppx/ocaml-migrate-parsetree#34 Thanks for all of the reviews and updates over the weekend! |
jberdine
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50 - this seems to be related to the move to a 4.06.0-based AST.