Improve begin/end position in match branches #2442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
reviewed
Sep 18, 2023
|
I believe #2438 is in fact asking for a new option. |
Julow
reviewed
Sep 18, 2023
| | B -> fooooooooooooo | ||
| | C -> fooooooooooooo | ||
| | D -> fooooooooooooo | ||
| end |
There was a problem hiding this comment.
This shows that for many values of break-cases, the end is aligned with the | of the pattern, which is ambiguous.
|
I'm not sure having yet-another-option is good in this case. We will do something nice for the diff-friendly profile and hope people stop using the other ones when they notice it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2438
The same thing would need to be done for if-then-else constructs so maybe some factorization would be in order.