Infer file kind for binary ASTs #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2019
aantron
added a commit
to aantron/bisect_ppx
that referenced
this pull request
Aug 23, 2019
The major part of #220. Most of the work as part of this change is in... - ocaml-ppx/ocaml-migrate-parsetree#80 - ocaml-ppx/ocaml-migrate-parsetree#81
ghost
suggested changes
Sep 4, 2019
|
I also merged |
Signed-off-by: Jeremie Dimino <[email protected]>
|
I've made |
ghost
merged commit
|
Thanks, that seems like a nice improvement. BTW, you might want to reproduce this change to ocaml-ppx/ppx at some point. The plan is that eventually it will replace the ocaml-migrate-parsetree driver entirely. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxes the driver command line parser so that if an input file is not specified with
--intfor--impl, but as an anonymous argument, and turns out to be a binary AST, the file kind is loaded from the file contents. Previously, the parser tried to guess the file kind from the extension. The extension is ignored completely now.This helps with BuckleScript integration, because current BuckleScript produces temporary binary AST files with no extension.