Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ocaml-migrate-parsetree-ocamlbuild on Travis #61

Closed
wants to merge 5 commits into from

Conversation

dra27
Copy link
Contributor

@dra27 dra27 commented Dec 19, 2018

No description provided.

@dra27
Copy link
Contributor Author

dra27 commented Dec 19, 2018

Not sure whether this tests the ocaml-migrate-parsetree-ocamlbuild from the pull request or from opam, so trying it initially...

@ghost
Copy link

ghost commented Dec 19, 2018

Shouldn't we move PACKAGE=xxx from global: to matrix: and test both cases?

@dra27
Copy link
Contributor Author

dra27 commented Dec 19, 2018

I guess so - it seems to be a limitation of the ocaml-ci-scripts tests.

@dra27 dra27 force-pushed the test-ocamlbuild branch 2 times, most recently from b412fdf to e2d39f5 Compare December 19, 2018 13:36
@dra27
Copy link
Contributor Author

dra27 commented Dec 19, 2018

There go another few rainforests on the altar of another stupid yaml file! I think that's doing what's wanted... I also added 4.07.1 testing while I was there

@ghost
Copy link

ghost commented Dec 19, 2018

I'm thinking that at this point we might just delete this package. It's probably being less and less used and the code pretty much never changed. It doesn't seem worth testing it continously.

@ghost
Copy link

ghost commented Dec 19, 2018

in fact:

$ opam list --depends-on ocaml-migrate-parsetree-ocamlbuild
# Packages matching: (installed | available) & depends-on(ocaml-migrate-parsetree-ocamlbuild)
# No matches found

@dra27
Copy link
Contributor Author

dra27 commented Dec 20, 2018

My only reservation is that this only tells you what opam-repository is doing - one gets no indication of its use by other non-visible opam remotes.

I've identified the problem - it's when Dune stopped depending on ocamlfind, so if you need the ocamlbuild on 4.02.3 then you need to be sure that ocamlfind is installed. I'll propose it on the opam-repository PR too.

@ghost
Copy link

ghost commented Jan 7, 2019

It doesn't seem worth making our life harder in this case. I'll create a PR to get rid of the ocamlbuild plugin.

@ghost ghost closed this Jan 7, 2019
@ghost ghost mentioned this pull request Jan 7, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant