Ensure stdout is in binary mode on Windows for --dump-ast #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this PR? The CI should pass now. |
dra27
force-pushed
the
binary-dump-ast
branch
from
1bb0b11 to
534ed9e
Compare
|
Hopefully it should pass CI now too - thanks @diml! |
ghost
merged commit
|
Thanks you both! I'll prepare a new release |
ghost
mentioned this pull request
|
Thanks, everyone! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix proposed in #57 works, but forcing channels to binary mode isn't always a good idea, because you can't at present restore them to whatever they were before. This alternate fix hopefully deals with the underlying problem.
@bryphe does this still fix the build?