Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project pages #121

Closed
wants to merge 12 commits into from
Closed

Project pages #121

wants to merge 12 commits into from

Conversation

samoht
Copy link
Contributor

@samoht samoht commented Aug 30, 2014

No description provided.

@samoht
Copy link
Contributor Author

samoht commented Aug 30, 2014

Not to merge yet, working on styling issues.

@dsheets
Copy link
Contributor

dsheets commented Sep 2, 2014

I like some of these changes. The ones I don't particularly like are the removal of the structured formula rendering entirely and the addition of a font size for versions to the generic CSS file.

There are some other minor points about line breaks, typography, version sorting, etc that I noticed but they are probably easiest to discuss in person.

@samoht
Copy link
Contributor Author

samoht commented Sep 11, 2014

I like some of these changes. The ones I don't particularly like are the removal of the structured formula rendering entirely and the addition of a font size for versions to the generic CSS file.

I really think that's important to keep the same format as in the opam format. Not sure what the geometric representation of expressions is really useful for.

@dsheets
Copy link
Contributor

dsheets commented Sep 22, 2014

It isn't the same format as opam, though. You can't copy and paste it into an opam file.

The "geometric" representation is, to me, much easier to read because the same kind of thing is in an expected place. I find mixing package names and version constraints to be noisier and harder to read and understand than simply a list that can be scanned vertically and then constraints that can be read horizontally.

Regardless, the ability to render in either way should not be removed from the software.

@samoht
Copy link
Contributor Author

samoht commented Dec 4, 2014

Closing as it has now been integrated in @dsheets branch (I think)

@samoht samoht closed this Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants