Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STM_domain.stress_test_par test #462

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

OlivierNicole
Copy link
Contributor

This is something that I found myself wanting for testing the concurrency-sensitive module Stdlib.Dynarray. The new function allows to get a more intensively parallel test without much additional effort, which helps to test for parallelism-related crashes.

@OlivierNicole OlivierNicole mentioned this pull request Jun 7, 2024
Copy link
Collaborator

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for this - I can definitely see this being useful!

There's something about returning an exception vs. a result that's confusing me (commented inline).

Also, please add a Changes entry - so that the addition is visible in the next release! 🙂

lib/STM_domain.ml Outdated Show resolved Hide resolved
lib/STM_domain.mli Show resolved Hide resolved
@OlivierNicole
Copy link
Contributor Author

Thank you for the review, I updated the PR accordingly.

@jmid
Copy link
Collaborator

jmid commented Jun 11, 2024

CI summary: All 36 workflows passed 🎉
Thanks again - I'll merge now

@jmid jmid merged commit 1a7d823 into ocaml-multicore:main Jun 11, 2024
30 checks passed
@OlivierNicole OlivierNicole deleted the stm-stress-test branch June 11, 2024 08:33
@jmid
Copy link
Collaborator

jmid commented Jun 11, 2024

CI summary for merge to main: All 37 workflows passed 😃

@jmid jmid mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants