Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -dtimings-precision flag #833

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Add -dtimings-precision flag #833

merged 2 commits into from
Sep 16, 2022

Conversation

azewierzejew
Copy link
Contributor

@azewierzejew azewierzejew commented Sep 15, 2022 •
edited
Loading

When using -dtimings flag to benchmark the compiler the values we get are seconds, rounded to the third decimal place.

When adding that for thousands of files the rounding error quickly adds up and can produces strange atrifacts in the summary.

This PR adds a new flag -dtimings-precision. With that the precision of the output can be changed. The default is 3 same as before.

@gretay-js
Copy link
Contributor

I don't think we need a new flag for it, I'd just change the output to have 6 instead of 3 digits precision.

@azewierzejew
Copy link
Contributor Author

I don't think we need a new flag for it, I'd just change the output to have 6 instead of 3 digits precision.

That's a valid point but I believe having choice is better for the human use as the output is easier to read.
I also would be scared of someone writing some hacky scripts that depend on the shape of the output with -dtimings

@gretay-js
Copy link
Contributor

I don't think we need a new flag for it, I'd just change the output to have 6 instead of 3 digits precision.

That's a valid point but I believe having choice is better for the human use as the output is easier to read. I also would be scared of someone writing some hacky scripts that depend on the shape of the output with -dtimings

We have too many flags. If we do end up with a new flag, I'd prefer the name to be more explicit, and easier to find next to the old flag, so something like -dtimings-high-precision.

@azewierzejew azewierzejew changed the title Add -dprec-timings flag Add -dtimings-precision flag Sep 15, 2022
gretay-js
gretay-js requested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@gretay-js gretay-js left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce the diff with upstream, is it possible to use !Clflags.timings_precision directly from Profile.time_display?

driver/optmaindriver.ml Show resolved Hide resolved
@azewierzejew
Copy link
Contributor Author

To reduce the diff with upstream, is it possible to use !Clflags.timings_precision directly from Profile.time_display?

Not possible (cyclical dependency).
I believe we would just have to put the val timings_precision : int ref in profile.ml.

@gretay-js
Copy link
Contributor

gretay-js commented Sep 16, 2022 •
edited
Loading

To reduce the diff with upstream, is it possible to use !Clflags.timings_precision directly from Profile.time_display?

Not possible (cyclical dependency).
ok, thanks.

I believe we would just have to put the val timings_precision : int ref in profile.ml.

no, it belongs in Clflags. Can you just add it to OCAMLPARAM please?

@mshinwell mshinwell merged commit 2678b86 into ocaml-flambda:main Sep 16, 2022
mshinwell added a commit to mshinwell/flambda-backend that referenced this pull request Oct 24, 2022
@mshinwell
Squashed 'ocaml/' changes from 2118848..25188da
db559ae 
25188da flambda-backend: Missed comment from PR802 (ocaml-flambda#887)
9469765 flambda-backend: Improve the semantics of asynchronous exceptions (new simpler version) (ocaml-flambda#802)
d9e4dd0 flambda-backend: Fix `make runtest` on NixOS (ocaml-flambda#874)
4bbde7a flambda-backend: Simpler symbols (ocaml-flambda#753)
ef37262 flambda-backend: Add opaqueness to Obj.magic under Flambda 2 (ocaml-flambda#862)
a9616e9 flambda-backend: Add build system hooks for ocaml-jst (ocaml-flambda#869)
045ef67 flambda-backend: Allow the compiler to build with stock Dune (ocaml-flambda#868)
3cac5be flambda-backend: Simplify Makefile logic for natdynlinkops (ocaml-flambda#866)
c5b12bf flambda-backend: Remove unnecessary install lines (ocaml-flambda#860)
ff12bbe flambda-backend: Fix unused variable warning in st_stubs.c (ocaml-flambda#861)
c84976c flambda-backend: Static check for noalloc: attributes (ocaml-flambda#825)
ca56052 flambda-backend: Build system refactoring for ocaml-jst (ocaml-flambda#857)
39eb7f9 flambda-backend: Remove integer comparison involving nonconstant polymorphic variants (ocaml-flambda#854)
c102688 flambda-backend: Fix soundness bug by using currying information from typing (ocaml-flambda#850)
6a96b61 flambda-backend: Add a primitive to enable/disable the tick thread (ocaml-flambda#852)
f64370b flambda-backend: Make Obj.dup use a new primitive, %obj_dup (ocaml-flambda#843)
9b78eb2 flambda-backend: Add test for ocaml-flambda#820 (include functor soundness bug) (ocaml-flambda#841)
8f24346 flambda-backend: Add `-dtimings-precision` flag (ocaml-flambda#833)
65c2f22 flambda-backend: Add test for ocaml-flambda#829 (ocaml-flambda#831)
7b27a49 flambda-backend: Follow-up PR#829 (comballoc fixes for locals) (ocaml-flambda#830)
ad7ec10 flambda-backend: Use a custom condition variable implementation (ocaml-flambda#787)
3ee650c flambda-backend: Fix soundness bug in include functor (ocaml-flambda#820)
2f57378 flambda-backend: Static check noalloc (ocaml-flambda#778)
aaad625 flambda-backend: Emit begin/end region only when stack allocation is enabled (ocaml-flambda#812)
17c7173 flambda-backend: Fix .cmt for included signatures (ocaml-flambda#803)
e119669 flambda-backend: Increase delays in tests/lib-threads/beat.ml (ocaml-flambda#800)
ccc356d flambda-backend: Prevent dynamic loading of the same .cmxs twice in private mode, etc. (ocaml-flambda#784)
14eb572 flambda-backend: Make local extension point equivalent to local_ expression (ocaml-flambda#790)
487d11b flambda-backend: Fix tast_iterator and tast_mapper for include functor. (ocaml-flambda#795)
a50a818 flambda-backend: Reduce closure allocation in List (ocaml-flambda#792)
96c9c60 flambda-backend: Merge ocaml-jst
a775b88 flambda-backend: Fix ocaml/otherlibs/unix 32-bit build (ocaml-flambda#767)
f7c2679 flambda-backend: Create object files internally to avoid invoking GAS (ocaml-flambda#757)
c7a46bb flambda-backend: Bugfix for Cmmgen.expr_size with locals (ocaml-flambda#756)
b337cb6 flambda-backend: Fix build_upstream for PR749 (ocaml-flambda#750)
8e7e81c flambda-backend: Differentiate is_int primitive between generic and variant-only versions (ocaml-flambda#749)

git-subtree-dir: ocaml
git-subtree-split: 25188da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretay-js gretay-js gretay-js approved these changes

@xclerc xclerc xclerc approved these changes

@mshinwell mshinwell mshinwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azewierzejew @gretay-js @mshinwell @xclerc