Ensure that all Bigarray memory managed by the GC is tracked by Memprof #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two cases where this was not already the case:
- Unix.map_file:
Fixed by adding memprof calls to mmap_ba.c
- User-allocated, GC-freed bigstrings:
These are allocated by calls to caml_ba_alloc with CAML_BA_MANAGED,
non-NULL data, and not CAML_BA_SUBARRAY (so new bigarrays, not slices)
Runtime5 already handled this case correctly. The fix for runtime4
is to add a new call to memprof for the missing case.
stedolan
force-pushed
the
fix-bigarray-memprof-tracking
branch
from
99c0ad0 to
c87664e
Compare
|
The build failure was #3358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two cases where this was not already the case:
Unix.map_file: Fixed by adding memprof calls to mmap_ba.c
User-allocated, GC-freed bigstrings: These are allocated by calls to caml_ba_alloc with CAML_BA_MANAGED, non-NULL data, and not CAML_BA_SUBARRAY (so new bigarrays, not slices)
Runtime5 already handled this case correctly. The fix for runtime4 is to add a new call to memprof for the missing case.