Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack checks for arm64 #2447

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Conversation

mshinwell
Copy link
Collaborator

This starts with #2442, #2443 and #2446. The remaining BACKPORT markers (except for one about DLS which will be dealt with in a separate PR) are removed from the arm64 emitter. I've then attempted to enable stack checks by wiring in the new Stack_check infrastructure.

Copy link
Contributor

@xclerc xclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am low confidence, but did not spot any
issues.

(Not right now, but when there are arm64
runner for the CI, I think we should consider
having a job testing arm64 with the debug
runtime.)

backend/arm64/emit.mlp Outdated Show resolved Hide resolved
@xclerc xclerc mentioned this pull request Apr 18, 2024
@mshinwell mshinwell merged commit cb0c14c into ocaml-flambda:main Apr 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants