Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caml_gc_compaction in the 5 runtime to run finalizers #2135

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix caml_gc_compaction in the 5 runtime to run finalizers #2135

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
872c489
Fix caml_gc_compaction to run finalizers
mshinwell Dec 8, 2023
5758db4
force_compaction
mshinwell Dec 11, 2023
9e8e9aa
Only compact on the third major cycle
mshinwell Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ocaml/runtime/gc_ctrl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,7 @@ CAMLprim value caml_gc_compaction(value v)
Caml_check_caml_state();
CAML_EV_BEGIN(EV_EXPLICIT_GC_COMPACT);
CAMLassert (v == Val_unit);
value exn = gc_major_exn(1);
++ Caml_state->stat_forced_major_collections;
value exn = gc_full_major_exn();
mshinwell marked this conversation as resolved.
Show resolved Hide resolved
CAML_EV_END(EV_EXPLICIT_GC_COMPACT);
return caml_raise_async_if_exception(exn, "");
}
Expand Down
Loading