Skip to content

Commit

Permalink
Update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
d-kalinichenko committed May 17, 2024
1 parent 6a3a688 commit c955bd8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion ocaml/typing/ctype.mli
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,8 @@ val check_type_externality : Env.t -> type_expr -> Jkind.Externality.t -> bool
itself.
2. Performs an upstream-compatibility check around immediacy if
[Language_extension.erasable_extensions_only ()] is [true].
[Language_extension.erasable_extensions_only ()] is [true]
and [upstream_compat] is [true].
The check makes sure no generalized type variable can have jkind
[immediate] or [immediate64]. An exception would be raised when
Expand Down
3 changes: 2 additions & 1 deletion ocaml/typing/typecore.ml
Original file line number Diff line number Diff line change
Expand Up @@ -8501,7 +8501,8 @@ and type_let ?check ?check_strict ?(force_toplevel = false)
| Tpat_alias(_, id, _, _, _) -> Some id
| _ -> None in
(* We don't need to check upstream compatibility for expressions:
just ensuring that annotations are erasable is enough. *)
just ensuring none of the type parameters of the function are
immediate is enough. *)
Ctype.check_and_update_generalized_ty_jkind
?name:pat_name ~loc:exp.exp_loc ~upstream_compat:false exp.exp_type
in
Expand Down

0 comments on commit c955bd8

Please sign in to comment.