Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking dependencies that fail with 4.14.0+trunk #250

Closed
shubhamkumar13 opened this issue Aug 1, 2021 · 3 comments
Closed

tracking dependencies that fail with 4.14.0+trunk #250

shubhamkumar13 opened this issue Aug 1, 2021 · 3 comments

Comments

@shubhamkumar13
Copy link
Contributor

shubhamkumar13 commented Aug 1, 2021

The following dependencies fail to build with 4.14.0+trunk + dune.2.9.0 with the sandmark ci.
This table contains a list of the packages and their respective issues

Dependency Github Issue
astring dbuenzli/astring#20
fmt dbuenzli/fmt#49
mtime dbuenzli/mtime#37
ocaml-migrate-parsetree ocaml-ppx/ocaml-migrate-parsetree#117
react dbuenzli/react#34
rresult dbuenzli/rresult#24

To make sure #247 is fixed with #249 the failing benchmarks are removed temporarily.

@dbuenzli
Copy link

dbuenzli commented Aug 1, 2021

I don't have the time to investigate this but I suspect something is wrong with the upstream install of compiler-libs.toplevel or they changed the installation/packaging scheme.

@dbuenzli
Copy link

dbuenzli commented Aug 5, 2021

It seems the reason was that Toploop.use_file was inadvertently nuked. A fix is being proposed upsteam ocaml/ocaml#10557

@shubhamkumar13
Copy link
Contributor Author

This issue can be closed because all the dependencies related 4.14.0+trunk has been resolved and the PR related to 4.14/0+trunk has been merged in #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants