-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandmark breaks on OCaml 4.14.0+trunk #247
Comments
@shubhamkumar13 This is high-priority for the compiler team. Please let's work on this. |
Yes I did looked into it yesterday and the issue seemed to be the dune variant.
But updating the dune version didn't fix it, there seem to be a lot of packages that might need updating and didn't build with trunk (I'm not sure why) which I'm planning to look at. I have the error log here. |
Thanks. Many packages are not expected to work with trunk. This may be due to several reasons. (1) It may be that trunk introduces a breaking change that makes the package not build with trunk. (2) It may be that the upper limit of the constraint is less than trunk's version; trunk always bumps the version number after a release. |
I tried to update the dependency packages to make sandmark work with 4.14.0+trunk.
The packages I also tested my branch with the other ci workflows locally and it seems to work without any issues. |
#251 resolves this issue |
See the failure in the CI at https://cloud.drone.io/ocaml-bench/sandmark/840/1/2. It would be useful to keep the CI green in the next few months as we head towards upstreaming multicore.
The text was updated successfully, but these errors were encountered: