Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qt Windows Extra for Qt 6 and later #5654

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

tommyvct
Copy link
Contributor

@tommyvct tommyvct commented Dec 13, 2021

Description

Remove Qt Windows Extra for Qt 6 and later

Motivation and Context

Qt 6 and later removed platform-specific extra modules from the code base.

How Has This Been Tested?

It compiles.
Tested on Windows 10 x64 and 11 ARM64 without crash.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

UI/CMakeLists.txt Outdated Show resolved Hide resolved
@tommyvct tommyvct force-pushed the remove-qtwinextra branch 2 times, most recently from f0d9933 to 3d0fd7a Compare December 13, 2021 10:24
@WizardCM WizardCM added the Windows Affects Windows label Dec 13, 2021
@tommyvct tommyvct marked this pull request as ready for review December 13, 2021 23:43
@tommyvct tommyvct mentioned this pull request Dec 13, 2021
19 tasks
@WizardCM
Copy link
Member

I can't decide if it's fine to have the same check written multiple times, or if there should be a variable that's reused instead.

@jp9000 jp9000 merged commit c83b758 into obsproject:master Dec 17, 2021
@WizardCM WizardCM added this to the OBS Studio 27.2 milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants