Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs/graphics: Add support for NT Handle shared textures #5518

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

VodBox
Copy link
Member

@VodBox VodBox commented Nov 11, 2021

Description

Adds support for using shared textures that were made with the
D3D11_RESOURCE_MISC_SHARED_NTHANDLE flag.

This increases the minimum required Windows version to Windows 8 or the
Platform Update for Windows 7. As official support is only for Win 8+
this does not change official support.

Motivation and Context

The new shared texture method required by our CEF branch uses shared textures made with the D3D11_RESOURCE_MISC_SHARED_NTHANDLE and D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX flags, so we need support for NT Handles.

How Has This Been Tested?

This has been tested against an implementation of the new shared texture method used in our CEF branch.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Nov 11, 2021
Copy link
Member

@notr1ch notr1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be split into separate commits? It affects both libobs-d3d11 and libobs.

libobs-d3d11/d3d11-texture2d.cpp Show resolved Hide resolved
libobs-d3d11/d3d11-subsystem.cpp Outdated Show resolved Hide resolved
VodBox added a commit to PatTheMav/obs-browser that referenced this pull request Nov 11, 2021
VodBox added a commit to PatTheMav/obs-browser that referenced this pull request Nov 18, 2021
Adds support for using shared textures that were made with the
D3D11_RESOURCE_MISC_SHARED_NTHANDLE flag.

This increases the minimum required Windows version to Windows 8 or the
Platform Update for Windows 7. As official support is only for Win 8+
this does not change official support.
@VodBox VodBox merged commit c8e4170 into obsproject:master Nov 20, 2021
@RytoEX RytoEX added this to the OBS Studio 27.2 milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants